Remove row > row nesting #1401
Merged
Remove row > row nesting #1401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes some alignment issues and removes some redundant classes. Closes #1318 See also geoblacklight/geoblacklight#1607
|
Easier to review with "hide whitespace" turned on. |
thatbudakguy
commented
Sep 11, 2024
| <% if (@document.image? || @document.item_viewer.iiif) && !@document[Settings.FIELDS[:GEOREFERENCED]] %> | ||
| <%= render AlertComponent.new(type: 'info', body: t('earthworks.show.no_georeference_message')) %> | ||
| <% end %> | ||
| <%= render Geoblacklight::ViewerContainerComponent.new(document: @document) %> |
There was a problem hiding this comment.
jcoyne
requested changes
Sep 16, 2024
| @@ -2,7 +2,7 @@ module EarthworksBlacklightHelper | |||
| include Blacklight::LayoutHelperBehavior | |||
| # Blacklight override for show main content | |||
| def show_content_classes | |||
There was a problem hiding this comment.
Can you remove this method override now? https://github.com/projectblacklight/blacklight/blob/c4ce13eee7eb0819c72f35a46db4eb565e6dfaa6/app/helpers/blacklight/layout_helper_behavior.rb#L32C1-L34C8 This seems to override with would almost be the same as the default now. Provided that
is okay for show.There was a problem hiding this comment.
Idk, the page looks pretty different if I remove it:
With col-lg-10:
With col-lg-9 (blacklight default):
I tried to change the col width for the map to expand to take up that new whitespace, but it caused it to wrap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some alignment issues and removes some redundant
classes.
Closes #1318
See also geoblacklight/geoblacklight#1607