Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dutch translation for Allies #441

Closed
wants to merge 2 commits into from
Closed

Conversation

Antheii
Copy link

@Antheii Antheii commented Jan 7, 2023

Dutch translation for Allies, hope I did correctly with those new gzip files

@sumpfork
Copy link
Owner

sumpfork commented Jan 7, 2023

Hi, thanks for contributing! Can you also check in the plain JSON files in the card_db_src folder that you (presumably) used to make these gz versions? The ones in the package you're checking in will just get erased if the changes aren't in the source files.

@Antheii
Copy link
Author

Antheii commented Jan 8, 2023 via email

@sumpfork sumpfork mentioned this pull request Jan 9, 2023
@sumpfork
Copy link
Owner

sumpfork commented Jan 9, 2023

I ran pre-commit (please read the README and install it in your checkout) and re-ran the card db compilation (it's out of date on this PR). Result is #448.

I'm also finding it hard to review the PR because a lot of the card entries moved around so they don't line up in the diff and I can't tell what got added/removed/translated/moved. I might enforce alphabetical sorting in the future, see #447.

That said, from spot checking the PDF looks good and I don't want to make translation work unduly difficult. I'm attaching a PDF here, could you check it?
dominion_dividers.pdf

@sumpfork sumpfork mentioned this pull request Jan 9, 2023
@Antheii
Copy link
Author

Antheii commented Jan 9, 2023 via email

sumpfork added a commit that referenced this pull request Jan 10, 2023
* Dutch translation for Allies

Authored-by: Antheii <[email protected]>
@sumpfork
Copy link
Owner

Replaced by #448

@sumpfork sumpfork closed this Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants