Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rising Sun setup #535

Merged
merged 8 commits into from
Sep 28, 2024
Merged

Rising Sun setup #535

merged 8 commits into from
Sep 28, 2024

Conversation

sumpfork
Copy link
Owner

Starting a Rising Sun PR based on #498 (comment)

Things I added:

  • preliminary images
  • test adjustments

Repository owner deleted a comment from github-actions bot Sep 24, 2024
Copy link

@spazard1 spazard1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

src/domdiv/images/sun.png Outdated Show resolved Hide resolved
src/domdiv/draw.py Outdated Show resolved Hide resolved
@TistoH
Copy link

TistoH commented Sep 27, 2024

Thank you all for the work involved in integrating this into the main db and creating new images. I only wish I could test it (my research says that a tool dependency prevents me from using cygwin as my development environment).

@nickv2002
Copy link
Collaborator

Thank you all for the work involved in integrating this into the main db and creating new images. I only wish I could test it (my research says that a tool dependency prevents me from using cygwin as my development environment).

If you can use docker images you might try those. There's some docs on the homepage that work fine on this rising_sun branch to compile and output PDFs.

@sumpfork sumpfork merged commit 1315391 into master Sep 28, 2024
7 checks passed
@sumpfork sumpfork deleted the rising_sun branch September 28, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants