Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SignInWithSso #94

Merged
merged 2 commits into from
May 31, 2024
Merged

Conversation

Rycko1
Copy link
Contributor

@Rycko1 Rycko1 commented May 31, 2024

What kind of change does this PR introduce?

Port the SignInWithSso functionality from the supabase auth js library into the csharp implementation found here

Bug fix, feature, docs update, ...

What is the current behavior?

#93

What is the new behavior?

Added SignInWithSSO functionality to both the API and Client layers. I skipped adding it to the stateless client because without making the HTTP request to the provider, there is no simple way to generate a stateless Url that can be used for authentication. If someone else can find a solution to this feel free to modify my code and pull request :)

I also added relevant error codes and handlers for any returned error related to SSO

Additional context

An example of a request once SSO is configured from the CLI and added to my supabase project
image

@acupofjose
Copy link
Collaborator

My apologies for taking so long to get back to you, it’s been quite a busy week. I’ll hopefully take a look at this in either the afternoon or over the weekend. Your work is much appreciated!

@acupofjose acupofjose merged commit 5acd1b2 into supabase-community:master May 31, 2024
1 check passed
@acupofjose
Copy link
Collaborator

Wonderful work @Rycko1! Very clean and clearly documented. If you have the chance, I'd love to have an example added to the wiki here (https://github.com/supabase-community/supabase-csharp/wiki/Authorization-with-Gotrue).

Otherwise, excited to include this in the next release!

@acupofjose
Copy link
Collaborator

I did rename to SignInWithSSO since it's an acronym and to match the JS client - available in [email protected]

@Rycko1 Rycko1 deleted the add_sso_signin branch May 31, 2024 19:31
@Rycko1
Copy link
Contributor Author

Rycko1 commented May 31, 2024

I did rename to SignInWithSSO since it's an acronym and to match the JS client - available in [email protected]

No worries at all! :) Glad I could help

@Rycko1
Copy link
Contributor Author

Rycko1 commented May 31, 2024

Wonderful work @Rycko1! Very clean and clearly documented. If you have the chance, I'd love to have an example added to the wiki here (https://github.com/supabase-community/supabase-csharp/wiki/Authorization-with-Gotrue).

Otherwise, excited to include this in the next release!

I can look into this later this weekend when I have more time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants