Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We depend on 3 deps:
which are hosted on JSR only (they are a part of Deno's standard lib). To make this work, JSR adds this to your
.npmrc
:So that JSR deps resolve through their own NPM-compat registry. This works great, unless you are publishing your own library. Published NPM packages don't include
.npmrc
(intentionally) so these deps aren't available to downstream users.Solution
Bundle them. We already use
tsup/esbuild
for internal bundling. To get these external deps to bundle, we just move them to dev dependencies andtsup
will pick them up.