-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: database deployment on Supabase #117
Draft
jgoux
wants to merge
39
commits into
main
Choose a base branch
from
feat/deploy-with-supabase
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the ability to deploy the in-browser database to Supabase.
I had to use a pretty complicated pipeline in order to do this:
This pipeline should be simplified once PGlite releases
pg_dump
in the browser, in which case we will be able to get rid of thebrowser-proxy
in this scenario.Infra tasks done:
deploy-worker
service on Fly staging environmentThings to polish:
Reliability of the deployment process, currently it's a giant function which creates a new Supabase project (first deployment), wait for the project to be healthy, and then do the data transfer.This will be done later using Supabase WorkflowsImplement the authorization flow in a new tab. Redirect to a "finalizing authorization" screen which will call the /oauth/callback api endpoint and communicate to the main tab through a BroadcastChannel on success. The main tab will then redirect to the deploy page.The app needs to be "locked" anyway so let's not overthink this and keep the current implementation.