Chore/use expandable textarea #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregnr
reviewed
Aug 13, 2024
There was a problem hiding this comment.
This is awesome 🚀 one thing that the previous input did was max out the number of expanded lines to 10 vs. growing infinitely. Do you think that's better or worse? (no strong opinions from me)
Also can we get the focus outline to go around the entire input container vs just the text area?
vs
Also noticing the background colour of the textarea is slightly different than the container (more apparent on dark mode, but I think is true for both themes)
Edit: possibly font size changed as well? Do we like it smaller or keep as before?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ports the chat box that the studio uses:
https://github.com/supabase/supabase/blob/master/packages/ui/src/components/ExpandingTextArea/index.tsx