feat(ssr): base64-encode cookie value #701
Conversation
| }, | ||
| setItem: async (key: string, value: string) => { | ||
| const chunks = await createChunks(key, value); | ||
| const chunks = await createChunks(key, encodeBase64Url(value)); |
There was a problem hiding this comment.
It'd also be possible to encode only the session, but checking for the name here seems error-prone.
|
I'd love to test this on my own project but was having trouble patching the @supabase/ssr package with this. Is there a way it can be done? |
|
If this is considered, it likely needs to use See #515 |
|
Will it work with unicode symbols in JSON? It can be user name for example |
|
@dalkommatt i typically do @jebibot we've decided to go with #726 to fix the cookie chunking issues so i'll be closing this PR. |
What kind of change does this PR introduce?
Feature
What is the current behavior?
The session cookie value is a plain JSON string, which gets URL-encoded by most server implementations. This causes a mismatch in the length calculation in the chunker; sometimes, cookie values exceed the max length.
What is the new behavior?
This PR base64-encodes the cookie value before passing to the chunker.
The rationale for using base64:
{,},",[,]to 3 characters tripling in length, whereas base64 encoding increasesx4/3in bytes, so the overall length would be similarAdditional context
Closes #680. Fixes #643 and fixes #696.