feat: no persist of session with no changes in _recoverAndRefresh (#…

…711) In `_recoverAndRefresh()` if the session was valid and not expired by the margin, it was loading and then persisting which could have overridden a new session value saved by another tab in local storage. This explains some errors where a refresh token is used again after a long time. --------- Co-authored-by: Joel Lee <[email protected]>
supabase · Jun 27, 2023 · 964f2fd · 964f2fd
1 parent 65f1c52
commit 964f2fd
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/GoTrueClient.ts b/src/GoTrueClient.ts
@@ -1283,9 +1283,9 @@ export default class GoTrueClient {
           }
         }
       } else {
-        if (this.persistSession) {
-          await this._saveSession(currentSession)
-        }
+        // no need to persist currentSession again, as we just loaded it from
+        // local storage; persisting it again may overwrite a value saved by
+        // another client with access to the same local storage
         await this._notifyAllSubscribers('SIGNED_IN', currentSession)
       }
     } catch (err) {