feat: refactor _handleRequest
#708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hf
force-pushed
the
hf/refactor-handle-request
branch
2 times, most recently
from
7c4c6c1
to
a858b14
Compare
hf
force-pushed
the
hf/refactor-handle-request
branch
from
a858b14
to
6ffd672
Compare
kangmingtay
approved these changes
Jun 27, 2023
|
🎉 This PR is included in version 2.33.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_handleRequestused a Promise instead of async/await which made traces difficult to debug. Additionally, it handles direct fetch errors which are always indicative of a network error, CORS or other such issues and propagtes the error directly.