feat: navigatorLock check for spec compatibility
#761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hf
force-pushed
the
hf/use-instanceof-navigator-lock-acquire-timeout
branch
from
8ad5b48
to
895b046
Compare
kangmingtay
approved these changes
Aug 21, 2023
hf
force-pushed
the
hf/use-instanceof-navigator-lock-acquire-timeout
branch
from
895b046
to
b165cb7
Compare
|
🎉 This PR is included in version 2.50.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like there are some instances where Chrome returns a
nulllock object from Navigator LockManager request even though this should only be the case ififAvailableis set totrue. This change logs a warning.