feat: add bindings for Multi-Factor Authentication (Phone) #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J0
commented
Jul 25, 2024
J0
commented
Aug 4, 2024
J0
commented
Aug 4, 2024
J0
commented
Aug 4, 2024
J0
commented
Aug 4, 2024
hf
approved these changes
Aug 5, 2024
J0
commented
Aug 9, 2024
J0
commented
Aug 9, 2024
J0
commented
Aug 9, 2024
hf
approved these changes
Aug 9, 2024
J0
changed the title
kangmingtay
pushed a commit
that referenced
this pull request
Aug 30, 2024
🤖 I have created a release *beep* *boop* --- ## [2.65.0](v2.64.4...v2.65.0) (2024-08-27) ### Features * add bindings for Multi-Factor Authentication (Phone) ([#932](#932)) ([b957c30](b957c30)) * add kakao to sign in with ID token ([#845](#845)) ([e2337ba](e2337ba)) * remove session, emit `SIGNED_OUT` when JWT `session_id` is invalid ([#905](#905)) ([db41710](db41710)) ### Bug Fixes * Correct typo in GoTrueClient warning message ([#938](#938)) ([8222ee1](8222ee1)) * don't throw error in exchangeCodeForSession ([#946](#946)) ([6e161ec](6e161ec)) * move docker compose to v2 ([#940](#940)) ([38eef89](38eef89)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Adds the bindings for MFA (Phone) Client library. In particular, add
TODOS:
totpfrom response field on enroll responseNot addressed yet
challengeAndVerifywill currently return an error on theverifystep when used with a phone factor. We could introduce an alternate behaviour (e.g. terminating at thechallengestep gracefully) since we have thetypeof the challenge-associated-factor in the response. This is not addressed in this PR