Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update workflow check-conventional-commits #962

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

staaldraad
Copy link
Contributor

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

Some github.event messages can break the workflow. Backticks get interpreted by the shell, this is a security risk and also breaks most Dependabot PRs.

What is the new behavior?

Updates the workflow to deal with special characters that might be interpreted by the shell

Additional context

Should fix https://github.com/supabase/auth-js/actions/runs/11035778554/job/30652617566

Updates the workflow to deal with the fact that ``` in the github.event
leading to code execution
@staaldraad staaldraad force-pushed the chore/update-workflows branch 2 times, most recently from 6bc8a8a to b72d213 Compare September 25, 2024 15:34
@staaldraad staaldraad requested a review from hf September 26, 2024 07:05
@kangmingtay kangmingtay merged commit ae73401 into master Oct 14, 2024
3 checks passed
@kangmingtay kangmingtay deleted the chore/update-workflows branch October 14, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants