Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "verify" flag to the creation of client #320

Closed
cyberillion opened this issue Apr 23, 2023 · 3 comments · Fixed by #506
Closed

Add "verify" flag to the creation of client #320

cyberillion opened this issue Apr 23, 2023 · 3 comments · Fixed by #506
Labels
enhancement New feature or request

Comments

@cyberillion
Copy link

Is your feature request related to a problem? Please describe.
In one of our prod environments, we have an SSL inspector, which means that sometimes we can't validate the certificate.
Right now, supabase-py just crashes when run in this environment.

Describe the solution you'd like
In gotrue's SyncClient, there is a "verify" parameter for init. I would like there to be a suitable flag in "create_client" function that will be passed on to the gotrue.

Describe alternatives you've considered
Right now, we're just overriding all the SyncClients in all the underlying clients that we use (auth, storage, postgres) with "verify=False", when needed.

Additional context
No additional context

@roiEshedCyberillium
Copy link

Yes!
we did this as well, it was quite tedious

@J0 J0 added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Sep 8, 2023
@J0 J0 transferred this issue from supabase/supabase-py Sep 15, 2023
@J0
Copy link
Contributor

J0 commented Sep 15, 2023

Hey team,

Thanks for patiently waiting. Can I check if this is still an issue?

@silentworks
Copy link
Contributor

I think this is still an issue since the verify property mentioned is from the httpx library and not the gotrue-py library itself.

@silentworks silentworks moved this to Todo in Supabase Python Oct 4, 2023
juancarlospaco added a commit to juancarlospaco/auth-py that referenced this issue May 28, 2024
juancarlospaco added a commit to juancarlospaco/auth-py that referenced this issue May 28, 2024
juancarlospaco added a commit to juancarlospaco/auth-py that referenced this issue May 28, 2024
juancarlospaco added a commit to juancarlospaco/auth-py that referenced this issue May 28, 2024
juancarlospaco added a commit to juancarlospaco/auth-py that referenced this issue May 28, 2024
juancarlospaco added a commit to juancarlospaco/auth-py that referenced this issue May 28, 2024
juancarlospaco added a commit to juancarlospaco/auth-py that referenced this issue May 28, 2024
juancarlospaco added a commit to juancarlospaco/auth-py that referenced this issue May 28, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Supabase Python Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants