-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
next release - feature parity - high testing coverage (Sourcery refactored) #172
Conversation
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 0.12%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Codecov ReportBase: 84.48% // Head: 84.45% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## next #172 +/- ##
==========================================
- Coverage 84.48% 84.45% -0.03%
==========================================
Files 14 14
Lines 1057 1055 -2
==========================================
- Hits 893 891 -2
Misses 164 164
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
f1f81ae
to
74bd57e
Compare
74bd57e
to
db7d95f
Compare
headers = {**self.headers} | ||
headers["Authorization"] = f"Bearer {jwt}" | ||
headers = {**self.headers, "Authorization": f"Bearer {jwt}"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function AsyncGoTrueAPI._create_request_headers
refactored with the following changes:
- Merge dictionary assignment with declaration (
merge-dict-assign
)
headers = {**self.headers} | ||
headers["Authorization"] = f"Bearer {jwt}" | ||
headers = {**self.headers, "Authorization": f"Bearer {jwt}"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function SyncGoTrueAPI._create_request_headers
refactored with the following changes:
- Merge dictionary assignment with declaration (
merge-dict-assign
)
Pull Request #148 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
next
branch, then run:Help us improve this pull request!