Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next release - feature parity - high testing coverage (Sourcery refactored) #172

Merged
merged 1 commit into from
Oct 9, 2022

Conversation

sourcery-ai[bot]
Copy link
Contributor

@sourcery-ai sourcery-ai bot commented Oct 9, 2022

Pull Request #148 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the next branch, then run:

git fetch origin sourcery/next
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

@sourcery-ai sourcery-ai bot requested a review from leynier October 9, 2022 05:25
@sourcery-ai
Copy link
Contributor Author

sourcery-ai bot commented Oct 9, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.12%.

Quality metrics Before After Change
Complexity 0.79 ⭐ 0.80 ⭐ 0.01 👎
Method Length 52.90 ⭐ 52.79 ⭐ -0.11 👍
Working memory 6.76 🙂 6.80 🙂 0.04 👎
Quality 80.78% 80.66% -0.12% 👎
Other metrics Before After Change
Lines 1232 1230 -2
Changed files Quality Before Quality After Quality Change
gotrue/_async/api.py 80.72% ⭐ 80.59% ⭐ -0.13% 👎
gotrue/_sync/api.py 80.85% ⭐ 80.72% ⭐ -0.13% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Oct 9, 2022

Codecov Report

Base: 84.48% // Head: 84.45% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (f1f81ae) compared to base (a322dce).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head f1f81ae differs from pull request most recent head db7d95f. Consider uploading reports for the commit db7d95f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             next     #172      +/-   ##
==========================================
- Coverage   84.48%   84.45%   -0.03%     
==========================================
  Files          14       14              
  Lines        1057     1055       -2     
==========================================
- Hits          893      891       -2     
  Misses        164      164              
Impacted Files Coverage Δ
gotrue/_async/api.py 69.82% <100.00%> (-0.18%) ⬇️
gotrue/_sync/api.py 69.82% <100.00%> (-0.18%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sourcery-ai sourcery-ai bot force-pushed the sourcery/next branch 2 times, most recently from f1f81ae to 74bd57e Compare October 9, 2022 05:30
headers = {**self.headers}
headers["Authorization"] = f"Bearer {jwt}"
headers = {**self.headers, "Authorization": f"Bearer {jwt}"}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function AsyncGoTrueAPI._create_request_headers refactored with the following changes:

headers = {**self.headers}
headers["Authorization"] = f"Bearer {jwt}"
headers = {**self.headers, "Authorization": f"Bearer {jwt}"}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function SyncGoTrueAPI._create_request_headers refactored with the following changes:

@leynier leynier merged commit 20b882c into next Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant