Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust timer units and drop * 1000 #220

Merged
merged 1 commit into from
Jan 29, 2023
Merged

fix: adjust timer units and drop * 1000 #220

merged 1 commit into from
Jan 29, 2023

Conversation

J0
Copy link
Contributor

@J0 J0 commented Jan 29, 2023

Timer takes in seconds and not milliseconds. Fixes #163 - see #163 for further details

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 29, 2023

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.01%.

Quality metrics Before After Change
Complexity 4.96 ⭐ 4.96 ⭐ 0.00
Method Length 60.81 ⭐ 60.74 ⭐ -0.07 👍
Working memory 7.66 🙂 7.66 🙂 0.00
Quality 72.04% 🙂 72.05% 🙂 0.01% 👍
Other metrics Before After Change
Lines 1224 1224 0
Changed files Quality Before Quality After Quality Change
gotrue/_async/client.py 71.91% 🙂 71.92% 🙂 0.01% 👍
gotrue/_sync/client.py 72.17% 🙂 72.18% 🙂 0.01% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
gotrue/_async/client.py AsyncGoTrueClient.get_session_from_url 15 🙂 252 ⛔ 13 😞 35.91% 😞 Try splitting into smaller methods. Extract out complex expressions
gotrue/_sync/client.py SyncGoTrueClient.get_session_from_url 15 🙂 250 ⛔ 13 😞 36.01% 😞 Try splitting into smaller methods. Extract out complex expressions
gotrue/_async/client.py AsyncGoTrueClient.sign_in 11 🙂 147 😞 13 😞 47.42% 😞 Try splitting into smaller methods. Extract out complex expressions
gotrue/_sync/client.py SyncGoTrueClient.sign_in 11 🙂 140 😞 13 😞 48.19% 😞 Try splitting into smaller methods. Extract out complex expressions
gotrue/_async/client.py AsyncGoTrueClient.__init__ 3 ⭐ 111 🙂 17 ⛔ 54.55% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Jan 29, 2023

Codecov Report

Base: 37.60% // Head: 37.60% // No change to project coverage 👍

Coverage data is based on head (78ed6d2) compared to base (b79e2a8).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #220   +/-   ##
=======================================
  Coverage   37.60%   37.60%           
=======================================
  Files          25       25           
  Lines        2284     2284           
=======================================
  Hits          859      859           
  Misses       1425     1425           
Impacted Files Coverage Δ
gotrue/_async/client.py 0.00% <ø> (ø)
gotrue/_sync/client.py 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@J0 J0 merged commit 758fb2f into main Jan 29, 2023
@J0 J0 deleted the j0/fix_timer_units branch January 29, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refresh token event not fired due to wrong unit of time in threading.Timer()
1 participant