fix: patch verify otp on test

supabase · Oct 1, 2024 · 474a4b6 · 474a4b6
1 parent a4285ae
commit 474a4b6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/internal/api/mfa.go b/internal/api/mfa.go
@@ -590,7 +590,10 @@ func (a *API) verifyPhoneFactor(w http.ResponseWriter, r *http.Request, params *
 	var otpCode string
 	var shouldReEncrypt bool
 	if config.Sms.IsTwilioVerifyProvider() {
-		smsProvider, _ := sms_provider.GetSmsProvider(*config)
+		smsProvider, err := sms_provider.GetSmsProvider(*config)
+		if err != nil {
+			return internalServerError("Failed to get SMS provider").WithInternalError(err)
+		}
 		if err := smsProvider.VerifyOTP(factor.Phone.String(), params.Code); err != nil {
 			return forbiddenError(ErrorCodeOTPExpired, "Token has expired or is invalid").WithInternalError(err)
 		}

diff --git a/internal/api/phone_test.go b/internal/api/phone_test.go
@@ -35,6 +35,9 @@ func (t *TestSmsProvider) SendMessage(phone, message, channel, otp string) (stri
 	t.SentMessages += 1
 	return "", nil
 }
+func (t *TestSmsProvider) VerifyOTP(phone, otp string) error {
+	return nil
+}
 
 func TestPhone(t *testing.T) {
 	api, config, err := setupAPIForTest()