Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade otel to v1.26 #1585

Merged
merged 12 commits into from
Jun 7, 2024
Merged

feat: upgrade otel to v1.26 #1585

merged 12 commits into from
Jun 7, 2024

Conversation

J0
Copy link
Contributor

@J0 J0 commented May 21, 2024 •
edited
Loading

What kind of change does this PR introduce?

Spiritual successor to #1305 where we attempt to bump the OTEL version from v1.10.0 to v1.26.0 which has a few breaking changes

How this was tested

We used a local setup with honeycomb with tracing and metrics enabled. We then triggered

  • a cleanup to test gotrue_cleanup_affected_rows
  • a few password sign ins to test gotrue_compare_hash_and_password_submitted
  • Checked if gotrue_running was present
  • Checked that DB traces were still present

DB Trace:

CleanShot 2024-05-23 at 20 46 02@2x

Metrics:

CleanShot 2024-05-23 at 20 41 51@2x

@coveralls
Copy link

coveralls commented May 22, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9416496963

Details

  • 21 of 79 (26.58%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 57.589%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/models/cleanup.go 6 9 66.67%
internal/observability/request-tracing.go 5 8 62.5%
internal/observability/metrics.go 3 55 5.45%
Totals Coverage Status
Change from base Build 9404687053: 0.03%
Covered Lines: 8507
Relevant Lines: 14772
💛 - Coveralls

@J0 J0 changed the title feat: upgrade otel feat: upgrade otel to v1.26 May 23, 2024
J0
J0 commented May 23, 2024
View reviewed changes
internal/api/opentelemetry-tracer_test.go Show resolved Hide resolved
internal/models/cleanup.go Show resolved Hide resolved
internal/models/cleanup.go Show resolved Hide resolved
@J0 J0 marked this pull request as ready for review May 23, 2024 18:53
@J0 J0 requested a review from a team as a code owner May 23, 2024 18:53
kangmingtay
kangmingtay reviewed May 29, 2024
View reviewed changes
internal/observability/metrics.go Show resolved Hide resolved
internal/observability/metrics.go Show resolved Hide resolved
internal/observability/metrics.go Outdated Show resolved Hide resolved
internal/api/middleware.go Outdated Show resolved Hide resolved
internal/models/cleanup.go Outdated Show resolved Hide resolved
hf
hf approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@hf hf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me at a first glance. If they end up in Honeycomb and the Prometheus server is serving up pretty-much the same metrics as before, address the comments from @kangmingtay and merge I guess.

@kangmingtay
Copy link
Member

nice work! feel free to resolve the comments and merge 👍

@J0
Copy link
Contributor Author

J0 commented Jun 6, 2024

Will merge in the evening, after some final sanity checks

@J0
Copy link
Contributor Author

J0 commented Jun 6, 2024

Might have to delay this to the morning, having slight issues pulling on the internet connection where I'm at.

@J0 J0 merged commit cdd13ad into master Jun 7, 2024
2 checks passed
@J0 J0 deleted the j0/upgrade_otel_deps branch June 7, 2024 11:54
@github-actions github-actions bot mentioned this pull request Jun 7, 2024
Merged
J0 pushed a commit that referenced this pull request Jun 14, 2024
@github-actions
chore(master): release 2.154.0 (#1610)
3cd00ee 
🤖 I have created a release *beep* *boop*
---


##
[2.154.0](v2.153.0...v2.154.0)
(2024-06-12)


### Features

* add max length check for email
([#1508](#1508))
([f9c13c0](f9c13c0))
* add support for Slack OAuth V2
([#1591](#1591))
([bb99251](bb99251))
* encrypt sensitive columns
([#1593](#1593))
([e4a4758](e4a4758))
* upgrade otel to v1.26
([#1585](#1585))
([cdd13ad](cdd13ad))
* use largest avatar from spotify instead
([#1210](#1210))
([4f9994b](4f9994b)),
closes [#1209](#1209)


### Bug Fixes

* define search path in auth functions
([#1616](#1616))
([357bda2](357bda2))
* enable rls & update grants for auth tables
([#1617](#1617))
([28967aa](28967aa))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
uxodb pushed a commit to uxodb/auth that referenced this pull request Nov 13, 2024
@J0
feat: upgrade otel to v1.26 (supabase#1585)
224fefe 
## What kind of change does this PR introduce?

Spiritual successor to supabase#1305 where we attempt to bump the OTEL version
from v1.10.0 to v1.26.0 which has a few breaking changes


## How this was tested

We used a local setup with honeycomb with tracing and metrics enabled.
We then triggered
- a cleanup to test `gotrue_cleanup_affected_rows`
- a few password sign ins to test
`gotrue_compare_hash_and_password_submitted`
- Checked if `gotrue_running` was present
- Checked that DB traces were still present

DB Trace:

<img width="1108" alt="CleanShot 2024-05-23 at 20 46 02@2x"
src="https://github.com/supabase/auth/assets/8011761/a365badb-08c3-4184-aef8-83624082d08d">


Metrics:

<img width="1064" alt="CleanShot 2024-05-23 at 20 41 51@2x"
src="https://github.com/supabase/auth/assets/8011761/1fc7743e-fc87-42a1-bf11-d14c739d5b67">
uxodb pushed a commit to uxodb/auth that referenced this pull request Nov 13, 2024
@github-actions
chore(master): release 2.154.0 (supabase#1610)
65fdd02 
🤖 I have created a release *beep* *boop*
---


##
[2.154.0](supabase/auth@v2.153.0...v2.154.0)
(2024-06-12)


### Features

* add max length check for email
([supabase#1508](supabase#1508))
([f9c13c0](supabase@f9c13c0))
* add support for Slack OAuth V2
([supabase#1591](supabase#1591))
([bb99251](supabase@bb99251))
* encrypt sensitive columns
([supabase#1593](supabase#1593))
([e4a4758](supabase@e4a4758))
* upgrade otel to v1.26
([supabase#1585](supabase#1585))
([cdd13ad](supabase@cdd13ad))
* use largest avatar from spotify instead
([supabase#1210](supabase#1210))
([4f9994b](supabase@4f9994b)),
closes [supabase#1209](supabase#1209)


### Bug Fixes

* define search path in auth functions
([supabase#1616](supabase#1616))
([357bda2](supabase@357bda2))
* enable rls & update grants for auth tables
([supabase#1617](supabase#1617))
([28967aa](supabase@28967aa))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 13, 2024
@J0 @LashaJini
feat: upgrade otel to v1.26 (supabase#1585)
70aebdd 
## What kind of change does this PR introduce?

Spiritual successor to supabase#1305 where we attempt to bump the OTEL version
from v1.10.0 to v1.26.0 which has a few breaking changes


## How this was tested

We used a local setup with honeycomb with tracing and metrics enabled.
We then triggered
- a cleanup to test `gotrue_cleanup_affected_rows`
- a few password sign ins to test
`gotrue_compare_hash_and_password_submitted`
- Checked if `gotrue_running` was present
- Checked that DB traces were still present

DB Trace:

<img width="1108" alt="CleanShot 2024-05-23 at 20 46 02@2x"
src="https://github.com/supabase/auth/assets/8011761/a365badb-08c3-4184-aef8-83624082d08d">


Metrics:

<img width="1064" alt="CleanShot 2024-05-23 at 20 41 51@2x"
src="https://github.com/supabase/auth/assets/8011761/1fc7743e-fc87-42a1-bf11-d14c739d5b67">
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 13, 2024
@github-actions @LashaJini
chore(master): release 2.154.0 (supabase#1610)
9dbbed6 
🤖 I have created a release *beep* *boop*
---


##
[2.154.0](supabase/auth@v2.153.0...v2.154.0)
(2024-06-12)


### Features

* add max length check for email
([supabase#1508](supabase#1508))
([f9c13c0](supabase@f9c13c0))
* add support for Slack OAuth V2
([supabase#1591](supabase#1591))
([bb99251](supabase@bb99251))
* encrypt sensitive columns
([supabase#1593](supabase#1593))
([e4a4758](supabase@e4a4758))
* upgrade otel to v1.26
([supabase#1585](supabase#1585))
([cdd13ad](supabase@cdd13ad))
* use largest avatar from spotify instead
([supabase#1210](supabase#1210))
([4f9994b](supabase@4f9994b)),
closes [supabase#1209](supabase#1209)


### Bug Fixes

* define search path in auth functions
([supabase#1616](supabase#1616))
([357bda2](supabase@357bda2))
* enable rls & update grants for auth tables
([supabase#1617](supabase#1617))
([28967aa](supabase@28967aa))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kangmingtay kangmingtay kangmingtay left review comments

@hf hf hf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@J0 @coveralls @kangmingtay @hf