feat: update dependencies (part 2/2, otel) #1305
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
November 9, 2023 14:37
J0
commented
Nov 14, 2023
| statusCode1 := getAttribute(attributes1, semconv.HTTPStatusCodeKey) | ||
| assert.Equal(ts.T(), int64(404), statusCode1.AsInt64()) | ||
|
|
||
| attributes2 := spans[1].Attributes() | ||
| method2 := getAttribute(attributes2, semconv.HTTPMethodKey) | ||
| assert.Equal(ts.T(), "GET", method2.AsString()) | ||
| url2 := getAttribute(attributes2, semconv.HTTPTargetKey) | ||
| assert.Equal(ts.T(), "http://localhost/something2", url2.AsString()) | ||
| // url2 := getAttribute(attributes2, semconv.HTTPTargetKey) |
There was a problem hiding this comment.
Might need help with getting this section to work - not sure how to best debug
|
Closed in favour of #1309 as we don't have bandwidth to test review such a large PR atm |
J0
added a commit
that referenced
this pull request
Jun 7, 2024
## What kind of change does this PR introduce? Spiritual successor to #1305 where we attempt to bump the OTEL version from v1.10.0 to v1.26.0 which has a few breaking changes ## How this was tested We used a local setup with honeycomb with tracing and metrics enabled. We then triggered - a cleanup to test `gotrue_cleanup_affected_rows` - a few password sign ins to test `gotrue_compare_hash_and_password_submitted` - Checked if `gotrue_running` was present - Checked that DB traces were still present DB Trace: <img width="1108" alt="CleanShot 2024-05-23 at 20 46 02@2x" src="https://github.com/supabase/auth/assets/8011761/a365badb-08c3-4184-aef8-83624082d08d"> Metrics: <img width="1064" alt="CleanShot 2024-05-23 at 20 41 51@2x" src="https://github.com/supabase/auth/assets/8011761/1fc7743e-fc87-42a1-bf11-d14c739d5b67">
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
## What kind of change does this PR introduce? Spiritual successor to supabase#1305 where we attempt to bump the OTEL version from v1.10.0 to v1.26.0 which has a few breaking changes ## How this was tested We used a local setup with honeycomb with tracing and metrics enabled. We then triggered - a cleanup to test `gotrue_cleanup_affected_rows` - a few password sign ins to test `gotrue_compare_hash_and_password_submitted` - Checked if `gotrue_running` was present - Checked that DB traces were still present DB Trace: <img width="1108" alt="CleanShot 2024-05-23 at 20 46 02@2x" src="https://github.com/supabase/auth/assets/8011761/a365badb-08c3-4184-aef8-83624082d08d"> Metrics: <img width="1064" alt="CleanShot 2024-05-23 at 20 41 51@2x" src="https://github.com/supabase/auth/assets/8011761/1fc7743e-fc87-42a1-bf11-d14c739d5b67">
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
## What kind of change does this PR introduce? Spiritual successor to supabase#1305 where we attempt to bump the OTEL version from v1.10.0 to v1.26.0 which has a few breaking changes ## How this was tested We used a local setup with honeycomb with tracing and metrics enabled. We then triggered - a cleanup to test `gotrue_cleanup_affected_rows` - a few password sign ins to test `gotrue_compare_hash_and_password_submitted` - Checked if `gotrue_running` was present - Checked that DB traces were still present DB Trace: <img width="1108" alt="CleanShot 2024-05-23 at 20 46 02@2x" src="https://github.com/supabase/auth/assets/8011761/a365badb-08c3-4184-aef8-83624082d08d"> Metrics: <img width="1064" alt="CleanShot 2024-05-23 at 20 41 51@2x" src="https://github.com/supabase/auth/assets/8011761/1fc7743e-fc87-42a1-bf11-d14c739d5b67">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Part 2/2, follow on from #1304