Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect schema regex #1719

Closed
pauldemarco opened this issue Aug 10, 2024 · 1 comment
Closed

Incorrect schema regex #1719

pauldemarco opened this issue Aug 10, 2024 · 1 comment

Comments

@pauldemarco
Copy link

The ^ character will disallow any of the characters within the group.
This should be removed to allow for providers names like google.

auth/openapi.yaml

Line 285 in 4b04327

pattern: "[^a-zA-Z0-9]+"

@hiteshbedre hiteshbedre mentioned this issue Aug 17, 2024
Merged
kangmingtay pushed a commit that referenced this issue Aug 19, 2024
@hiteshbedre
chore: updated regex for provider name (#1723)
0658bbe 
## What kind of change does this PR introduce?

Bug fix

## What is the current behavior?

A valid provider name gets invalidated.

## What is the new behavior?

A possible valid provider name gets verified by regex correctly.

## Additional context

`[^a]+` -> This regex will match any char except character `a`
`^a$` -> This regex will match string have single char `a`
`^[a-zA-Z0-9]+$` -> This regex will match any alphanumeric string. `^`
denotes start of string and `$` denotes end of string.

This pull request will address
#1719
@kangmingtay
Copy link
Member

@pauldemarco closing since this has been fixed by @hiteshbedre 🎉

uxodb pushed a commit to uxodb/auth that referenced this issue Nov 13, 2024
@hiteshbedre
chore: updated regex for provider name (supabase#1723)
dc794dc 
## What kind of change does this PR introduce?

Bug fix

## What is the current behavior?

A valid provider name gets invalidated.

## What is the new behavior?

A possible valid provider name gets verified by regex correctly.

## Additional context

`[^a]+` -> This regex will match any char except character `a`
`^a$` -> This regex will match string have single char `a`
`^[a-zA-Z0-9]+$` -> This regex will match any alphanumeric string. `^`
denotes start of string and `$` denotes end of string.

This pull request will address
supabase#1719
LashaJini pushed a commit to LashaJini/auth that referenced this issue Nov 13, 2024
@hiteshbedre @LashaJini
chore: updated regex for provider name (supabase#1723)
df3cba5 
## What kind of change does this PR introduce?

Bug fix

## What is the current behavior?

A valid provider name gets invalidated.

## What is the new behavior?

A possible valid provider name gets verified by regex correctly.

## Additional context

`[^a]+` -> This regex will match any char except character `a`
`^a$` -> This regex will match string have single char `a`
`^[a-zA-Z0-9]+$` -> This regex will match any alphanumeric string. `^`
denotes start of string and `$` denotes end of string.

This pull request will address
supabase#1719
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pauldemarco @kangmingtay