Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow anonymous user to update password #1739

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

kangmingtay
Copy link
Member

What kind of change does this PR introduce?

What is the current behavior?

  • an anonymous cannot update their password unless they confirm their email first - this is not ideal since it requires the anonymous user to verify the email first before adding a password to their account

Please link any relevant issues here.

What is the new behavior?

Feel free to include screenshots if it includes visual changes.

Additional context

  • An anonymous user remains anonymous until they have confirmed the email / phone added

Add any other context or screenshots.

@kangmingtay kangmingtay requested a review from a team as a code owner August 23, 2024 20:48
@coveralls
Copy link

coveralls commented Aug 23, 2024

Pull Request Test Coverage Report for Build 10532410671

Details

  • 2 of 4 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 57.972%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/api/user.go 2 4 50.0%
Totals Coverage Status
Change from base Build 10522515960: 0.001%
Covered Lines: 9210
Relevant Lines: 15887

💛 - Coveralls

@kangmingtay kangmingtay merged commit 2d51956 into master Aug 26, 2024
2 checks passed
@kangmingtay kangmingtay deleted the km/fix-anonymous-user-linking branch August 26, 2024 04:08
kangmingtay pushed a commit that referenced this pull request Aug 28, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.159.2](v2.159.1...v2.159.2)
(2024-08-28)


### Bug Fixes

* allow anonymous user to update password
([#1739](#1739))
([2d51956](2d51956))
* hide hook name ([#1743](#1743))
([7e38f4c](7e38f4c))
* remove server side cookie token methods
([#1742](#1742))
([c6efec4](c6efec4))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
uxodb pushed a commit to uxodb/auth that referenced this pull request Nov 13, 2024
uxodb pushed a commit to uxodb/auth that referenced this pull request Nov 13, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.159.2](supabase/auth@v2.159.1...v2.159.2)
(2024-08-28)


### Bug Fixes

* allow anonymous user to update password
([supabase#1739](supabase#1739))
([2d51956](supabase@2d51956))
* hide hook name ([supabase#1743](supabase#1743))
([7e38f4c](supabase@7e38f4c))
* remove server side cookie token methods
([supabase#1742](supabase#1742))
([c6efec4](supabase@c6efec4))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 13, 2024
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 13, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.159.2](supabase/auth@v2.159.1...v2.159.2)
(2024-08-28)


### Bug Fixes

* allow anonymous user to update password
([supabase#1739](supabase#1739))
([2d51956](supabase@2d51956))
* hide hook name ([supabase#1743](supabase#1743))
([7e38f4c](supabase@7e38f4c))
* remove server side cookie token methods
([supabase#1742](supabase#1742))
([c6efec4](supabase@c6efec4))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Anonymous users can't sign up with passwords
3 participants