Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add msg91 as phone provider (fork of #989) #1018

Closed
wants to merge 13 commits into from
Closed

Conversation

hf
Copy link
Contributor

@hf hf commented Apr 3, 2023

Same as #989 with some technical details resolved.

@hf hf requested a review from a team as a code owner April 3, 2023 15:17
@hf hf force-pushed the community/msg91 branch 2 times, most recently from 40f8591 to 180b707 Compare July 3, 2023 16:09
@paigham-tech
Copy link

Hey @MeetChaudhari @hf @kangmingtay any update for this ? Went through comments on #989, it looks like this won't be merged until webhook solution is implemented. So, any idea about what is the status on webhook solution ?

This is turning out to be a blocker for Indian Startups. Hope we receive a update soon. Thanks!!

@MeetChaudhari
Copy link

Hey @MeetChaudhari @hf @kangmingtay any update for this ? Went through comments on #989, it looks like this won't be merged until webhook solution is implemented. So, any idea about what is the status on webhook solution ?

This is turning out to be a blocker for Indian Startups. Hope we receive a update soon. Thanks!!

I completely agree with you @paigham-tech , even our startup had to go with a different implementation than supabase just due to this auth provider thing,

But as i am aware, the webhook based auth implementation is pending from supabase team side, @hf please correct me if i am wrong.

@paigham-tech As soon as supabase team implements webhook based system, ill write the webhook based integration or whatever required for Msg91 support.

@rohankm
Copy link

rohankm commented Feb 13, 2024

Waiting for this

@J0
Copy link
Contributor

J0 commented Feb 21, 2024

Hey @MeetChaudhari,

Thanks for the implementation. We're implementing it now and will circle back with further updates soon. I'm heading to India this weekend and hope to test it then if I can get a number. I'm going to close this PR for now but will reach back out once we're closer to completion on the hook implementation

Let us know if there are further queries.

Thanks

@J0 J0 closed this Feb 21, 2024
@rohankm
Copy link

rohankm commented Mar 19, 2024

Hey @MeetChaudhari,

Thanks for the implementation. We're implementing it now and will circle back with further updates soon. I'm heading to India this weekend and hope to test it then if I can get a number. I'm going to close this PR for now but will reach back out once we're closer to completion on the hook implementation

Let us know if there are further queries.

Thanks

what is the status?

@J0
Copy link
Contributor

J0 commented Mar 19, 2024

Hey @rohankm,

Thanks for checking in. Feel free to follow along on #1474. Testing some final bits.

@J0
Copy link
Contributor

J0 commented May 7, 2024

Hey @rohankm @MeetChaudhari,

Thanks for patiently waiting. We'll be moving forward with the Hooks implementation soon and are open to taking contributions for a msg91 -here's what it looks like for Twilio

If you're still keen on adding Msg91 as a custom SMS provider feel free to let me know and will follow up with next steps.

Thanks!

@MeetChaudhari
Copy link

Hey @rohankm @MeetChaudhari,

Thanks for patiently waiting. We'll be moving forward with the Hooks implementation soon and are open to taking contributions for a msg91 -here's what it looks like for Twilio

If you're still keen on adding Msg91 as a custom SMS provider feel free to let me know and will follow up with next steps.

Thanks!

Hey @J0,

Thanks for reaching out, yes I am still up for integration of msg91, how can we proceed.

@rohankm
Copy link

rohankm commented May 7, 2024

Hi,
I have already implemented msg91 and its working fine.
Here is the fork https://github.com/rohankm/gotrue.git

@MeetChaudhari
Copy link

Hi,
I have already implemented msg91 and its working fine.
Here is the fork https://github.com/rohankm/gotrue.git

Hey, @rohankm

I haven't checked the fork, but if it's based on my fork of initial implementation then it won't work as the supabase team is switching to an webhook based implementation which @J0 is talking about.

@rohankm
Copy link

rohankm commented May 7, 2024

Hi,
I have already implemented msg91 and its working fine.
Here is the fork https://github.com/rohankm/gotrue.git

Hey, @rohankm

I haven't checked the fork, but if it's based on my fork of initial implementation then it won't work as the supabase team is switching to an webhook based implementation which @J0 is talking about.

I understand but I didn't have time to wait for the supabase team to implement it and its not based on webhooks

@MeetChaudhari
Copy link

Hi,
I have already implemented msg91 and its working fine.
Here is the fork https://github.com/rohankm/gotrue.git

Hey, @rohankm

I haven't checked the fork, but if it's based on my fork of initial implementation then it won't work as the supabase team is switching to an webhook based implementation which @J0 is talking about.

I understand but I didn't have time to wait for the supabase team to implement it and its not based on webhooks

Yup, I got it bro anyways none of our implementation will move forward, as now it has to be webhook based one, I'll start working on it as soon as @J0 pings me up with necessary stuff, I am right now studying the example implementation of twilio which he shared.

@J0
Copy link
Contributor

J0 commented May 7, 2024

@MeetChaudhari do you have Discord? If so I'll open a thread there with details there and tag you - else I can open a Github issue or discussion in this repo and tag you

Actually, let's stick to Github for visibility - will open an issue.

@MeetChaudhari
Copy link

MeetChaudhari commented May 7, 2024

@MeetChaudhari do you have Discord? If so I'll open a thread there with details there and tag you - else I can open a Github issue or discussion in this repo and tag you

Actually, let's stick to Github for visibility - will open an issue.

My discord username - kreferlink,

Ya it's fine let's stick to GitHub.

@rohankm
Copy link

rohankm commented May 22, 2024

@J0 @MeetChaudhari any progress?

@MeetChaudhari
Copy link

@J0 @MeetChaudhari any progress?

Was Stuck in something, will start today

@J0
Copy link
Contributor

J0 commented May 22, 2024

No worries - feel free to ping me if there's anything confusing

@J0
Copy link
Contributor

J0 commented May 28, 2024

Folks, checking in - any issues here or anything we can help with?

@rohankm
Copy link

rohankm commented Jun 16, 2024

@MeetChaudhari are you working on this?

@MeetChaudhari
Copy link

@MeetChaudhari are you working on this?

Yes, mostly it will be done within the next week or so, it's delayed as I am working on so many things together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants