-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add msg91 as phone provider (fork of #989) #1018
Conversation
Co-authored-by: Stojan Dimitrovski <[email protected]>
Co-authored-by: Stojan Dimitrovski <[email protected]>
removed pluginsource flag
40f8591
to
180b707
Compare
Hey @MeetChaudhari @hf @kangmingtay any update for this ? Went through comments on #989, it looks like this won't be merged until webhook solution is implemented. So, any idea about what is the status on webhook solution ? This is turning out to be a blocker for Indian Startups. Hope we receive a update soon. Thanks!! |
I completely agree with you @paigham-tech , even our startup had to go with a different implementation than supabase just due to this auth provider thing, But as i am aware, the webhook based auth implementation is pending from supabase team side, @hf please correct me if i am wrong. @paigham-tech As soon as supabase team implements webhook based system, ill write the webhook based integration or whatever required for Msg91 support. |
Waiting for this |
Hey @MeetChaudhari, Thanks for the implementation. We're implementing it now and will circle back with further updates soon. I'm heading to India this weekend and hope to test it then if I can get a number. I'm going to close this PR for now but will reach back out once we're closer to completion on the hook implementation Let us know if there are further queries. Thanks |
what is the status? |
Hey @rohankm @MeetChaudhari, Thanks for patiently waiting. We'll be moving forward with the Hooks implementation soon and are open to taking contributions for a msg91 -here's what it looks like for Twilio If you're still keen on adding Msg91 as a custom SMS provider feel free to let me know and will follow up with next steps. Thanks! |
Hey @J0, Thanks for reaching out, yes I am still up for integration of msg91, how can we proceed. |
Hi, |
Hey, @rohankm I haven't checked the fork, but if it's based on my fork of initial implementation then it won't work as the supabase team is switching to an webhook based implementation which @J0 is talking about. |
I understand but I didn't have time to wait for the supabase team to implement it and its not based on webhooks |
Yup, I got it bro anyways none of our implementation will move forward, as now it has to be webhook based one, I'll start working on it as soon as @J0 pings me up with necessary stuff, I am right now studying the example implementation of twilio which he shared. |
@MeetChaudhari do you have Discord? If so I'll open a thread there with details there and tag you - else I can open a Github issue or discussion in this repo and tag you Actually, let's stick to Github for visibility - will open an issue. |
My discord username - kreferlink, Ya it's fine let's stick to GitHub. |
@J0 @MeetChaudhari any progress? |
Was Stuck in something, will start today |
No worries - feel free to ping me if there's anything confusing |
Folks, checking in - any issues here or anything we can help with? |
@MeetChaudhari are you working on this? |
Yes, mostly it will be done within the next week or so, it's delayed as I am working on so many things together. |
Same as #989 with some technical details resolved.