Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add profiler server #1158

Merged
merged 5 commits into from
Jun 28, 2023
Merged

fix: add profiler server #1158

merged 5 commits into from
Jun 28, 2023

Conversation

kangmingtay
Copy link
Member

@kangmingtay kangmingtay commented Jun 28, 2023 •
edited
Loading

What kind of change does this PR introduce?

  • Adds a profiler server (pprof) to gotrue

@kangmingtay kangmingtay requested a review from a team as a code owner June 28, 2023 06:30
hf
hf reviewed Jun 28, 2023
View reviewed changes
internal/api/api.go Outdated Show resolved Hide resolved
@kangmingtay kangmingtay changed the title fix: add pprof middleware fix: add profiler server Jun 28, 2023
hf
hf reviewed Jun 28, 2023
View reviewed changes
internal/conf/profiler.go Outdated Show resolved Hide resolved
cmd/serve_cmd.go Outdated Show resolved Hide resolved
@hf
Copy link
Contributor

hf commented Jun 28, 2023

Also I think it's best if you setup the new server properly, not with the http.ListenAndServe as it still registers the routes. You can use the https://pkg.go.dev/net/http/pprof#Handler function with a new server object.

@kangmingtay kangmingtay merged commit 58552d6 into master Jun 28, 2023
@kangmingtay kangmingtay deleted the km/add-pprof branch June 28, 2023 11:13
@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.77.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

uxodb pushed a commit to uxodb/auth that referenced this pull request Nov 13, 2024
@kangmingtay
fix: add profiler server (supabase#1158)
5d208c5
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 13, 2024
@kangmingtay @LashaJini
fix: add profiler server (supabase#1158)
8eed322
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 15, 2024
@kangmingtay @LashaJini
fix: add profiler server (supabase#1158)
640d0a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hf hf hf approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kangmingtay @hf