-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: deprecate existing webhook implementation #1417
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J0
force-pushed
the
j0/deprecate_existing_hooks_implementation
branch
from
February 12, 2024 04:52
005ab4b
to
4ebf71b
Compare
kangmingtay
approved these changes
Feb 13, 2024
J0
pushed a commit
that referenced
this pull request
Feb 13, 2024
🤖 I have created a release *beep* *boop* --- ## [2.140.0](v2.139.2...v2.140.0) (2024-02-13) ### Features * deprecate existing webhook implementation ([#1417](#1417)) ([5301e48](5301e48)) * update publish.yml checkout repository so there is access to Dockerfile ([#1419](#1419)) ([7cce351](7cce351)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Merged
J0
added a commit
that referenced
this pull request
Feb 15, 2024
## What kind of change does this PR introduce? Follow up to #1417 which removes the code which is involved as well as the environment variables. Should only be merged after #1417 has had time to sit for a few days --------- Co-authored-by: joel <[email protected]>
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
## What kind of change does this PR introduce? We deprecate the existing HTTP webhook implementation to make way for Auth HTTP Hooks. We put up a deprecation notice as a warning and fully deprecate the configuration in the next release ## What is the current behavior? We have webhooks but it is unused on the Supabase Auth platform ## What is the new behavior? We remove webhooks in this PR and add [Standard Webhooks compliant](https://www.standardwebhooks.com/) HTTP Hooks. We should also add a deprecation notice on the release ## Additional context --------- Co-authored-by: joel <[email protected]>
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
🤖 I have created a release *beep* *boop* --- ## [2.140.0](supabase/auth@v2.139.2...v2.140.0) (2024-02-13) ### Features * deprecate existing webhook implementation ([supabase#1417](supabase#1417)) ([5301e48](supabase@5301e48)) * update publish.yml checkout repository so there is access to Dockerfile ([supabase#1419](supabase#1419)) ([7cce351](supabase@7cce351)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
## What kind of change does this PR introduce? Follow up to supabase#1417 which removes the code which is involved as well as the environment variables. Should only be merged after supabase#1417 has had time to sit for a few days --------- Co-authored-by: joel <[email protected]>
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
## What kind of change does this PR introduce? We deprecate the existing HTTP webhook implementation to make way for Auth HTTP Hooks. We put up a deprecation notice as a warning and fully deprecate the configuration in the next release ## What is the current behavior? We have webhooks but it is unused on the Supabase Auth platform ## What is the new behavior? We remove webhooks in this PR and add [Standard Webhooks compliant](https://www.standardwebhooks.com/) HTTP Hooks. We should also add a deprecation notice on the release ## Additional context --------- Co-authored-by: joel <[email protected]>
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
🤖 I have created a release *beep* *boop* --- ## [2.140.0](supabase/auth@v2.139.2...v2.140.0) (2024-02-13) ### Features * deprecate existing webhook implementation ([supabase#1417](supabase#1417)) ([5301e48](supabase@5301e48)) * update publish.yml checkout repository so there is access to Dockerfile ([supabase#1419](supabase#1419)) ([7cce351](supabase@7cce351)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
## What kind of change does this PR introduce? Follow up to supabase#1417 which removes the code which is involved as well as the environment variables. Should only be merged after supabase#1417 has had time to sit for a few days --------- Co-authored-by: joel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
We deprecate the existing HTTP webhook implementation to make way for Auth HTTP Hooks. We put up a deprecation notice as a warning and fully deprecate the configuration in the next release
What is the current behavior?
We have webhooks but it is unused on the Supabase Auth platform
What is the new behavior?
We remove webhooks in this PR and add Standard Webhooks compliant HTTP Hooks.
We should also add a deprecation notice on the release
Additional context