Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate existing webhook implementation #1417

Merged
merged 3 commits into from
Feb 13, 2024

Conversation

J0
Copy link
Contributor

@J0 J0 commented Feb 12, 2024

What kind of change does this PR introduce?

We deprecate the existing HTTP webhook implementation to make way for Auth HTTP Hooks. We put up a deprecation notice as a warning and fully deprecate the configuration in the next release

What is the current behavior?

We have webhooks but it is unused on the Supabase Auth platform

What is the new behavior?

We remove webhooks in this PR and add Standard Webhooks compliant HTTP Hooks.

We should also add a deprecation notice on the release

Additional context

@J0 J0 force-pushed the j0/deprecate_existing_hooks_implementation branch from 005ab4b to 4ebf71b Compare February 12, 2024 04:52
@J0 J0 marked this pull request as ready for review February 12, 2024 05:00
@J0 J0 requested a review from a team as a code owner February 12, 2024 05:00
@J0 J0 merged commit 5301e48 into master Feb 13, 2024
4 checks passed
@J0 J0 deleted the j0/deprecate_existing_hooks_implementation branch February 13, 2024 03:58
J0 pushed a commit that referenced this pull request Feb 13, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.140.0](v2.139.2...v2.140.0)
(2024-02-13)


### Features

* deprecate existing webhook implementation
([#1417](#1417))
([5301e48](5301e48))
* update publish.yml checkout repository so there is access to
Dockerfile ([#1419](#1419))
([7cce351](7cce351))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@J0 J0 mentioned this pull request Feb 13, 2024
J0 added a commit that referenced this pull request Feb 15, 2024
## What kind of change does this PR introduce?

Follow up to #1417 which removes the code which is involved as well as
the environment variables. Should only be merged after #1417 has had
time to sit for a few days

---------

Co-authored-by: joel <[email protected]>
uxodb pushed a commit to uxodb/auth that referenced this pull request Nov 13, 2024
## What kind of change does this PR introduce?

We deprecate the existing HTTP webhook implementation to make way for
Auth HTTP Hooks. We put up a deprecation notice as a warning and fully
deprecate the configuration in the next release

## What is the current behavior?

We have webhooks but it is unused on the Supabase Auth platform

## What is the new behavior?

We remove webhooks in this PR and add [Standard Webhooks
compliant](https://www.standardwebhooks.com/) HTTP Hooks.

We should also add a deprecation notice on the release

## Additional context

---------

Co-authored-by: joel <[email protected]>
uxodb pushed a commit to uxodb/auth that referenced this pull request Nov 13, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.140.0](supabase/auth@v2.139.2...v2.140.0)
(2024-02-13)


### Features

* deprecate existing webhook implementation
([supabase#1417](supabase#1417))
([5301e48](supabase@5301e48))
* update publish.yml checkout repository so there is access to
Dockerfile ([supabase#1419](supabase#1419))
([7cce351](supabase@7cce351))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
uxodb pushed a commit to uxodb/auth that referenced this pull request Nov 13, 2024
## What kind of change does this PR introduce?

Follow up to supabase#1417 which removes the code which is involved as well as
the environment variables. Should only be merged after supabase#1417 has had
time to sit for a few days

---------

Co-authored-by: joel <[email protected]>
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 13, 2024
## What kind of change does this PR introduce?

We deprecate the existing HTTP webhook implementation to make way for
Auth HTTP Hooks. We put up a deprecation notice as a warning and fully
deprecate the configuration in the next release

## What is the current behavior?

We have webhooks but it is unused on the Supabase Auth platform

## What is the new behavior?

We remove webhooks in this PR and add [Standard Webhooks
compliant](https://www.standardwebhooks.com/) HTTP Hooks.

We should also add a deprecation notice on the release

## Additional context

---------

Co-authored-by: joel <[email protected]>
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 13, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.140.0](supabase/auth@v2.139.2...v2.140.0)
(2024-02-13)


### Features

* deprecate existing webhook implementation
([supabase#1417](supabase#1417))
([5301e48](supabase@5301e48))
* update publish.yml checkout repository so there is access to
Dockerfile ([supabase#1419](supabase#1419))
([7cce351](supabase@7cce351))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 13, 2024
## What kind of change does this PR introduce?

Follow up to supabase#1417 which removes the code which is involved as well as
the environment variables. Should only be merged after supabase#1417 has had
time to sit for a few days

---------

Co-authored-by: joel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants