fix: improve token OIDC logging #1606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kangmingtay
commented
Jun 3, 2024
Pull Request Test Coverage Report for Build 9345543792Details
💛 - Coveralls |
J0
approved these changes
Jun 3, 2024
kangmingtay
pushed a commit
that referenced
this pull request
Jun 6, 2024
🤖 I have created a release *beep* *boop* --- ## [2.153.0](v2.152.0...v2.153.0) (2024-06-04) ### Features * add SAML specific external URL config ([#1599](#1599)) ([b352719](b352719)) * add support for verifying argon2i and argon2id passwords ([#1597](#1597)) ([55409f7](55409f7)) * make the email client explicity set the format to be HTML ([#1149](#1149)) ([53e223a](53e223a)) ### Bug Fixes * call write header in write if not written ([#1598](#1598)) ([0ef7eb3](0ef7eb3)) * deadlock issue with timeout middleware write ([#1595](#1595)) ([6c9fbd4](6c9fbd4)) * improve token OIDC logging ([#1606](#1606)) ([5262683](5262683)) * update contributing to use v1.22 ([#1609](#1609)) ([5894d9e](5894d9e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
## What kind of change does this PR introduce? * Currently, when the "Unacceptable audience in id_token" error is returned, it doesn't log the audience claim from the id token, which makes it hard to debug. The audience claim from the id token is now logged as well when this error is returned. * Adds a basic test for the generic id token oidc `getProvider()` method, since we currently have 0 coverage for this file * The test also uncovered a possible nil pointer panic in the case of the generic OIDC provider being returned since in the generic case, the `oauthConfig` will be nil. Rather than returning the `oauthConfig`, we only need to return the `skipNonceCheck` property since we only check for that.
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
🤖 I have created a release *beep* *boop* --- ## [2.153.0](supabase/auth@v2.152.0...v2.153.0) (2024-06-04) ### Features * add SAML specific external URL config ([supabase#1599](supabase#1599)) ([b352719](supabase@b352719)) * add support for verifying argon2i and argon2id passwords ([supabase#1597](supabase#1597)) ([55409f7](supabase@55409f7)) * make the email client explicity set the format to be HTML ([supabase#1149](supabase#1149)) ([53e223a](supabase@53e223a)) ### Bug Fixes * call write header in write if not written ([supabase#1598](supabase#1598)) ([0ef7eb3](supabase@0ef7eb3)) * deadlock issue with timeout middleware write ([supabase#1595](supabase#1595)) ([6c9fbd4](supabase@6c9fbd4)) * improve token OIDC logging ([supabase#1606](supabase#1606)) ([5262683](supabase@5262683)) * update contributing to use v1.22 ([supabase#1609](supabase#1609)) ([5894d9e](supabase@5894d9e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
## What kind of change does this PR introduce? * Currently, when the "Unacceptable audience in id_token" error is returned, it doesn't log the audience claim from the id token, which makes it hard to debug. The audience claim from the id token is now logged as well when this error is returned. * Adds a basic test for the generic id token oidc `getProvider()` method, since we currently have 0 coverage for this file * The test also uncovered a possible nil pointer panic in the case of the generic OIDC provider being returned since in the generic case, the `oauthConfig` will be nil. Rather than returning the `oauthConfig`, we only need to return the `skipNonceCheck` property since we only check for that.
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
🤖 I have created a release *beep* *boop* --- ## [2.153.0](supabase/auth@v2.152.0...v2.153.0) (2024-06-04) ### Features * add SAML specific external URL config ([supabase#1599](supabase#1599)) ([b352719](supabase@b352719)) * add support for verifying argon2i and argon2id passwords ([supabase#1597](supabase#1597)) ([55409f7](supabase@55409f7)) * make the email client explicity set the format to be HTML ([supabase#1149](supabase#1149)) ([53e223a](supabase@53e223a)) ### Bug Fixes * call write header in write if not written ([supabase#1598](supabase#1598)) ([0ef7eb3](supabase@0ef7eb3)) * deadlock issue with timeout middleware write ([supabase#1595](supabase#1595)) ([6c9fbd4](supabase@6c9fbd4)) * improve token OIDC logging ([supabase#1606](supabase#1606)) ([5262683](supabase@5262683)) * update contributing to use v1.22 ([supabase#1609](supabase#1609)) ([5894d9e](supabase@5894d9e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
getProvider()method, since we currently have 0 coverage for this fileoauthConfigwill be nil. Rather than returning theoauthConfig, we only need to return theskipNonceCheckproperty since we only check for that.