fix: check for empty aud string #1649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J0
approved these changes
Jul 4, 2024
kangmingtay
force-pushed
the
km/check-empty-aud
branch
from
7c2f1b4
to
7e28c66
Compare
Pull Request Test Coverage Report for Build 9798599120Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9798617222Details
💛 - Coveralls |
kangmingtay
force-pushed
the
km/check-empty-aud
branch
from
7e28c66
to
97e14fe
Compare
Pull Request Test Coverage Report for Build 9798705324Details
💛 - Coveralls |
kangmingtay
pushed a commit
that referenced
this pull request
Jul 4, 2024
🤖 I have created a release *beep* *boop* --- ## [2.155.1](v2.155.0...v2.155.1) (2024-07-04) ### Bug Fixes * apply mailer autoconfirm config to update user email ([#1646](#1646)) ([a518505](a518505)) * check for empty aud string ([#1649](#1649)) ([42c1d45](42c1d45)) * return proper error if sms rate limit is exceeded ([#1647](#1647)) ([3c8d765](3c8d765)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
## What kind of change does this PR introduce? * Fixes an issue where an empty string set as the `aud` claim will cause some methods to fail ## What is the current behavior? Please link any relevant issues here. ## What is the new behavior? Feel free to include screenshots if it includes visual changes. ## Additional context Add any other context or screenshots.
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
🤖 I have created a release *beep* *boop* --- ## [2.155.1](supabase/auth@v2.155.0...v2.155.1) (2024-07-04) ### Bug Fixes * apply mailer autoconfirm config to update user email ([supabase#1646](supabase#1646)) ([a518505](supabase@a518505)) * check for empty aud string ([supabase#1649](supabase#1649)) ([42c1d45](supabase@42c1d45)) * return proper error if sms rate limit is exceeded ([supabase#1647](supabase#1647)) ([3c8d765](supabase@3c8d765)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
## What kind of change does this PR introduce? * Fixes an issue where an empty string set as the `aud` claim will cause some methods to fail ## What is the current behavior? Please link any relevant issues here. ## What is the new behavior? Feel free to include screenshots if it includes visual changes. ## Additional context Add any other context or screenshots.
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
🤖 I have created a release *beep* *boop* --- ## [2.155.1](supabase/auth@v2.155.0...v2.155.1) (2024-07-04) ### Bug Fixes * apply mailer autoconfirm config to update user email ([supabase#1646](supabase#1646)) ([a518505](supabase@a518505)) * check for empty aud string ([supabase#1649](supabase#1649)) ([42c1d45](supabase@42c1d45)) * return proper error if sms rate limit is exceeded ([supabase#1647](supabase#1647)) ([3c8d765](supabase@3c8d765)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
audclaim will cause some methods to failWhat is the current behavior?
Please link any relevant issues here.
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.