Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ordering on JSON columns #132

Merged
merged 1 commit into from
Nov 12, 2020
Merged

Fix ordering on JSON columns #132

merged 1 commit into from
Nov 12, 2020

Conversation

soedirgo
Copy link
Member

What kind of change does this PR introduce?

Bug fix.

What is the new behavior?

Previously, order columns wrap the column name in quotes to allow
characters like . without having the user wrap it manually, but this
breaks on JSON columns, so we're removing the quotes.

Additional context

Closes #131.

Previously, `order` columns wrap the column name in quotes to allow
characters like `.` without having the user wrap it manually, but this
breaks on JSON columns, so we're removing the quotes.
@kiwicopple
Copy link
Member

Niice @soedirgo

@kiwicopple kiwicopple merged commit c92493e into master Nov 12, 2020
@kiwicopple kiwicopple deleted the fix/order-column branch November 12, 2020 09:46
@github-actions
Copy link

🎉 This PR is included in version 0.21.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ordering JSON column not working
2 participants