Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Check if url is a WS URL #227

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: Check if url is a WS URL #227

wants to merge 5 commits into from
+8 −0

Conversation

juancarlospaco
Copy link
Contributor

What kind of change does this PR introduce?

  • Check if url arg is a WebSocket URL.

@juancarlospaco juancarlospaco marked this pull request as ready for review November 1, 2024 11:53
@silentworks
Copy link
Contributor

I don't think this check is necessary as the code is already converting http and https to ws and wss. https://github.com/supabase/realtime-py/blob/main/realtime/_async/client.py#L60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juancarlospaco @silentworks