Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make download key optional #153

Merged
merged 2 commits into from
Sep 28, 2023
Merged

fix: make download key optional #153

merged 2 commits into from
Sep 28, 2023

Conversation

anand2312
Copy link
Contributor

Make "download" key optional for create_signed_url; without this passing {} as the options argument would make the static type-checker complain

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (bf49d51) 84.70% compared to head (fc93662) 84.70%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #153   +/-   ##
=======================================
  Coverage   84.70%   84.70%           
=======================================
  Files          12       12           
  Lines         451      451           
=======================================
  Hits          382      382           
  Misses         69       69           
Files Coverage Δ
storage3/types.py 95.91% <100.00%> (ø)
storage3/_async/file_api.py 83.20% <0.00%> (ø)
storage3/_sync/file_api.py 83.20% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@silentworks
Copy link
Collaborator

Doesn't this require the sync client to be updated too? or is this done automatically by the CI pipeline?

@anand2312
Copy link
Contributor Author

anand2312 commented Sep 28, 2023

@silentworks good catch, i forgot to run unasync because i initially only planned on changing types.py. we could possibly run unasync in the CI too.

@anand2312 anand2312 merged commit d0c47c7 into main Sep 28, 2023
12 checks passed
@anand2312 anand2312 deleted the fix/remove-required-key branch September 28, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants