-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add logging #1042
feat: Add logging #1042
Conversation
@dshukertjr For now, I've only added logging to the gotrue package. What do you think of this? If you consent, I would add this to the rest of the packages. |
This is awesome! I love it so much! |
I've noticed that we should be careful with what data we log, especially sensitive data. So I've come up with the idea that records with level |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
I see now that there is no documentation in the README of the rest of the packages. So I would leave it for now only in the supabase_flutter package and you? or I? add it to the supabase website documentation. |
What kind of change does this PR introduce?
feature
What is the current behavior?
When debugging the auth broadcasting or the realtime/stream fixed I had to manually add many print statements, which was annoying. The js sdk already has some logging.
What is the new behavior?
Add logging via the logging package from dart.dev. This primarily only tracks the logs. When
debug
is true in the supabase_flutterSupabase
instance, records with levelINFO
or higher are printed.The logger instances are laid in a hierarchy separated by dots, which allows all supabase loggers to be united in a
supabase
logger instance.