fix(gotrue): Signing in does not remove the session unless the operation succeeds. #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kangmingtay
approved these changes
Jun 10, 2024
|
Just noticed that there are a bunch of errors on the tests. Looking into it right now. |
Vinzent03
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Currently, the SDK removes the session whenever a user tries to sign-in / sign-up. If the operation fails, the user is signed out from the original session they had. This PR fixes the behavior so that the session is not removed.
What is the new behavior?
The user's session is not removed at the beginning of calling sign-in / sign-up methods, and they will keep the existing session if the sign-in / sign-up operation fails.
Additional context
JS PR: supabase/auth-js#915