Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: linux build #350

Merged
merged 9 commits into from
Apr 22, 2024
Merged

fix: linux build #350

merged 9 commits into from
Apr 22, 2024

Conversation

grdsdev
Copy link
Collaborator

@grdsdev grdsdev commented Apr 19, 2024 •
edited
Loading

What kind of change does this PR introduce?

  • Fixes some issues building the library in Linux/Windows.
  • Adds a Supported Platforms section to README making it clear the Linux/Windows aren't officially supported and may stop working on future versions.

See discussion in #337

@grdsdev grdsdev force-pushed the fix/linux-build branch 3 times, most recently from 871930a to 87ff515 Compare April 19, 2024 19:46
@grdsdev grdsdev mentioned this pull request Apr 22, 2024
Closed
@grdsdev grdsdev requested a review from dshukertjr April 22, 2024 08:29
@grdsdev grdsdev marked this pull request as ready for review April 22, 2024 08:29
dshukertjr
dshukertjr approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@dshukertjr dshukertjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! There is one test that is failing, but everything else looks good.

@grdsdev grdsdev merged commit e62ad89 into main Apr 22, 2024
49 checks passed
@grdsdev grdsdev deleted the fix/linux-build branch April 22, 2024 11:41
@github-actions github-actions bot mentioned this pull request Apr 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dshukertjr dshukertjr dshukertjr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grdsdev @dshukertjr