Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: remove support for Windows/Linux #337

Closed
wants to merge 3 commits into from

Conversation

grdsdev
Copy link
Collaborator

@grdsdev grdsdev commented Apr 12, 2024

What kind of change does this PR introduce?

For the official support we're focusing only on the Apple platform, so I'm removing the current code handling Windows/Linux support.

@grdsdev grdsdev force-pushed the chore/remove-windows-linux-support branch from 35bef2e to a936f8f Compare April 12, 2024 13:00
@grdsdev grdsdev requested a review from dshukertjr April 12, 2024 13:04
@mergesort
Copy link

mergesort commented Apr 12, 2024

Hey @grdsdev, I was wondering what suggestions you would have for me to continue using Supabase on Linux? I have a good amount of production code using Supabase on Linux since it was added to the official library, so I consider this a really big breaking change not to be taken lightly — especially since Linux is an officially supported platform of Swift.

@brianmichel
Copy link
Contributor

brianmichel commented Apr 12, 2024

Personally I can understand the complexity of not wanting to support Windows as it's very much evolving, however I would say that removing all Linux support feels like a miss for me.

Why limit the usability and reach of an SDK, is this just a resourcing problem?

Granted, this is not my repo, but as a customer this feels bad.

@grdsdev grdsdev changed the title feat: remove support for Windows/Linux feat!: remove support for Windows/Linux Apr 15, 2024
@grdsdev grdsdev changed the title feat!: remove support for Windows/Linux chore!: remove support for Windows/Linux Apr 15, 2024
@grdsdev grdsdev marked this pull request as draft April 15, 2024 12:53
@grdsdev grdsdev force-pushed the chore/remove-windows-linux-support branch from df3e04e to 303b58b Compare April 16, 2024 08:16
@grdsdev grdsdev force-pushed the chore/remove-windows-linux-support branch from 303b58b to 9960acc Compare April 18, 2024 18:15
@grdsdev
Copy link
Collaborator Author

grdsdev commented Apr 22, 2024

@mergesort and @brianmichel, thanks for bringing in your points to the discussion.

I decided to keep the current code as it is working, but we're not officially supporting Linux and Windows for now on.

I'll close this PR in favor of #350 which fixes a couple of issues with Linux build and adds a Supported Platform to the README that makes this more clear.


Also, if you guys wants to support it, PRs are always welcome.

@grdsdev grdsdev closed this Apr 22, 2024
@grdsdev grdsdev deleted the chore/remove-windows-linux-support branch April 22, 2024 08:26
@grdsdev grdsdev mentioned this pull request Apr 22, 2024
@mergesort
Copy link

Thank you so much @grdsdev, I truly appreciate that you're keeping unofficial support for Linux around! I'll make sure to do my best to fix any issues I encounter on Linux, and if not will create issues to see if we can work to solve them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants