Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix query type #518

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

varchugov
Copy link

@varchugov varchugov commented Jun 1, 2021

I use the RouterState interface in my DefaultRootState, but I can get an error in js when I use non-existent parameters

query parameters may be missing;
query is an empty object by default 1 2
And this is a fix for the discussion

@varchugov
Copy link
Author

@supasate Could you take a look at the pull reguest?

@supasate
Copy link
Owner

supasate commented Sep 7, 2021

Hi @varchugov, could you help provide reproducible steps (or minimal repo that can reproduce the issue)?

Using Partial still requires query to be existed (but its keys can be optional).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants