Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow disabling autosending metrics #112

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

TheEdward162
Copy link
Contributor

Description

Allows disabling the automatic sending of metrics and on exit hooks. Metrics are still generated and need to be consumed periodically - this might need to be changed later.

Motivation and Context

During initial performance testing (see #108) this was required but this usecase might be important, and it is already implemented for cloudflare host.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Copy link
Member

@freaz freaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@TheEdward162 TheEdward162 merged commit 10d3f0f into main Oct 12, 2023
5 checks passed
@TheEdward162 TheEdward162 deleted the feat/allow_disable_autosending_metrics branch October 12, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants