feat: improve map-std types #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* made MapError generic over the value it stores * made UsecaseContext and UsecaseFn generic over input, result and error * export MapError and AnyValue types into the global namespace of the map-std types (this is sort of like stabilising them, but they are just types and we don't currently distribute those) * correctly type Response.bodyJson and Response.bodyAuto (add Buffer into the possible return types) * improve Buffer.from to also accept Bytes * update example maps with more correct typings * fix provider parameters type to only string values * fix FetchOptions.body type to AnyValue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some improvements I realized can be useful as I was experimenting with TypeScript profiles