Feat/nodejs comlink package #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheEdward162
force-pushed
the
feat/nodejs_comlink_package
branch
7 times, most recently
from
0277cbd
to
ef52550
Compare
* also add bundler to comlink_language_server
* ensure that schemas generated for profile input, result and error are valid json schemas even in case of parsing errors (although they might be trivial in that case) * this allows better integration with json schema types in POD * emit error when profile has no Use cases
* profile id and version are not currently present in the profile document * add convenience to nodejs_comlink package to parse them from file name in the parseProfile function
* update actions checkout, cache, download-artifact, upload-artifact, setup-node, setup-python to newest major version * separate map_std, nodejs_comlink and comlink_language_server into a separate workflow * abstract core_build action, which takes care of building any core component (core.wasm, test-core.wasm, comlink.wasm) * remove option to build all hosts at once, it doesn't properly work anyway * add changelogs, version files, gitignore
TheEdward162
force-pushed
the
feat/nodejs_comlink_package
branch
from
ef52550
to
c204b6b
Compare
* use the same version in VERSION file and package.json in new packages * remove incorrect comment * remove misplaced tab character
freaz
approved these changes
Feb 7, 2024
| import { | ||
| DocumentUri, | ||
| TextDocumentContentChangeEvent, | ||
| } from 'vscode-languageserver'; | ||
|
|
||
| import { ComlinkDocument } from './document'; | ||
| import { stripUriPrefix } from './lib'; | ||
| import { Diagnostic, Profile, ProfileSpans } from './parser/model'; | ||
| import { Diagnostic, Profile, ProfileSpans } from '@superfaceai/comlink'; |
There was a problem hiding this comment.
How does it work with linked package? It works thanks to bundling right?
There was a problem hiding this comment.
Yes, since this is basically a "binary" release (as opposed to a library), and I was using it this way during development. It's a good question whether we want to keep it this way or add a proper npm dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft because: