feat: remove transmuter/overhaul transmutation #23

0xTimepunk · 2023-10-26T11:18:49Z

Fixes partially https://github.com/code-423n4/2023-09-superform/issues/73

Remainder of fix in superform-core repo

src/ERC1155A.sol

src/sERC20.sol

gpersoon · 2023-10-27T07:43:14Z

src/ERC1155A.sol

-
-        return synthethicTokenId[id];
-    }
+    function registerSERC20(uint256 id) external virtual override returns (address);


I assume you want to delegate the erc20 creating itself to another contract.
Even then it might still be good to keep the logic with synthethicTokenId[] inside this contract, to isolate it and to prevent mistakes.

if (synthethicTokenId[id] != address(0)) revert SYNTHETIC_ERC20_ALREADY_REGISTERED(); address syntheticToken = createToken(id); // done elsewhere synthethicTokenId[id] = syntheticToken; return synthethicTokenId[id];

src/ERC1155A.sol

gpersoon · 2023-10-27T07:50:36Z

src/ERC1155A.sol

            // If not, then check if the msg.sender has sufficient allowance
-            require(allowance(from, msg.sender, id) >= amount, "NOT_AUTHORIZED");
-            allowances[from][msg.sender][id] -= amount; // Deduct the burned amount from the allowance
+            require(allowance(from, operator, id) >= amount, "NOT_AUTHORIZED");


string based error message (could be custom error)

src/ERC1155A.sol

gpersoon · 2023-10-27T07:53:03Z

src/ERC1155A.sol

+    }
+
+    /// @dev handy helper to check if a SERC20 is registered
+    function _sERC20Exists(uint256 id) external view virtual returns (bool) {


external function but name starts with an _

gpersoon · 2023-10-27T07:53:52Z

src/interfaces/IERC1155A.sol

+    /// @param id id of the ERC1155 to get the synthetic token address for
+    /// @return sERC20 address of the synthetic token for the given ERC1155 id
+    function getSyntheticTokenAddress(uint256 id) external view returns (address sERC20);
+


could add function _sERC20Exists(uint256 id)

gpersoon · 2023-10-27T07:55:55Z

src/sERC20.sol

@@ -8,6 +8,7 @@ import { ERC20 } from "openzeppelin-contracts/contracts/token/ERC20/ERC20.sol";
 /// @dev Synthetic ERC20 tokens out of 1155a
 contract sERC20 is ERC20 {
    address public immutable ERC1155A;
+    uint8 private immutable tokenDecimals;


there is no interface file for sERC20 e.g. ISERC20.SOL, might be useful to have

gpersoon · 2023-10-27T07:57:36Z

src/sERC20.sol

@@ -31,4 +33,8 @@ contract sERC20 is ERC20 {

        _burn(owner, amount);
    }
+


nitpick: spender could be operator in function burn

feat: remove transmuter/overhaul transmutation

cf38620

0xTimepunk requested review from vikramarun and sujithsomraaj October 26, 2023 11:18