Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert args as calldata #32

Merged
merged 1 commit into from
Dec 26, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 18 additions & 18 deletions src/ERC1155A.sol
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@ abstract contract ERC1155A is IERC1155A, IERC1155Errors {

/// @inheritdoc IERC1155
function balanceOfBatch(
address[] calldata owners,
uint256[] calldata ids
address[] memory owners,
uint256[] memory ids
)
public
view
Expand Down Expand Up @@ -158,8 +158,8 @@ abstract contract ERC1155A is IERC1155A, IERC1155Errors {
/// @inheritdoc IERC1155A
function increaseAllowanceForMany(
address operator,
uint256[] calldata ids,
uint256[] calldata addedValues
uint256[] memory ids,
uint256[] memory addedValues
)
public
virtual
Expand All @@ -178,8 +178,8 @@ abstract contract ERC1155A is IERC1155A, IERC1155Errors {
/// @inheritdoc IERC1155A
function decreaseAllowanceForMany(
address operator,
uint256[] calldata ids,
uint256[] calldata subtractedValues
uint256[] memory ids,
uint256[] memory subtractedValues
)
public
virtual
Expand Down Expand Up @@ -207,7 +207,7 @@ abstract contract ERC1155A is IERC1155A, IERC1155Errors {
address to,
uint256 id,
uint256 amount,
bytes calldata data
bytes memory data
)
public
virtual
Expand Down Expand Up @@ -237,9 +237,9 @@ abstract contract ERC1155A is IERC1155A, IERC1155Errors {
function safeBatchTransferFrom(
address from,
address to,
uint256[] calldata ids,
uint256[] calldata amounts,
bytes calldata data
uint256[] memory ids,
uint256[] memory amounts,
bytes memory data
)
public
virtual
Expand Down Expand Up @@ -307,8 +307,8 @@ abstract contract ERC1155A is IERC1155A, IERC1155Errors {
/// @inheritdoc IERC1155A
function transmuteBatchToERC20(
address owner,
uint256[] calldata ids,
uint256[] calldata amounts,
uint256[] memory ids,
uint256[] memory amounts,
address receiver
)
external
Expand All @@ -335,8 +335,8 @@ abstract contract ERC1155A is IERC1155A, IERC1155Errors {
/// @inheritdoc IERC1155A
function transmuteBatchToERC1155A(
address owner,
uint256[] calldata ids,
uint256[] calldata amounts,
uint256[] memory ids,
uint256[] memory amounts,
address receiver
)
external
Expand Down Expand Up @@ -407,8 +407,8 @@ abstract contract ERC1155A is IERC1155A, IERC1155Errors {
function _batchMint(
address to,
address operator,
uint256[] calldata ids,
uint256[] calldata amounts,
uint256[] memory ids,
uint256[] memory amounts,
bytes memory data
)
internal
Expand Down Expand Up @@ -451,8 +451,8 @@ abstract contract ERC1155A is IERC1155A, IERC1155Errors {
function _batchBurn(
address from,
address operator,
uint256[] calldata ids,
uint256[] calldata amounts
uint256[] memory ids,
uint256[] memory amounts
)
internal
virtual
Expand Down