[FEATURE] ext:form Finisher support #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Classes/Hooks/Backend/ItemsProcFunc.php
# Conflicts: # Classes/Hooks/Backend/ItemsProcFunc.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a Finisher which accepts first name, last name, email and Interests selection as options. These additions essentially allow the user to reimagine the existing form—provided by the
mailchimp_registrationplugin—in the Form Framework. This allows for cohesion with the rest of a site's forms and styles, removing the need to create a separate form for just Mailchimp.Caveat: Used API, List, and Interests (
api_key,list_id,interest_id) must still be configured in the Flexform/Finisher override as opposed to the Forms module.I don't see that problem being resolved until ext:form adds hooks similar to ItemsProcFunc for the Form editor.