Updated Licensing cache system + versioning #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se in both deactivate and cache-expired
ManiruzzamanAkash
changed the title
|
@ajgagnon I've not changed the namespace yet, may be after your review will update that. |
ajgagnon
reviewed
Jun 2, 2023
| if ( ! class_exists( 'SureCart\Licensing\Client' ) ) { | ||
| require_once __DIR__ . '/licensing/src/Client.php'; | ||
| } | ||
| require_once __DIR__ . '/licensing/SureCartSdkLoader.php'; |
There was a problem hiding this comment.
Did you test this with this sdk in 2 plugin directories? I would assume this may fail because they are being required in 2 different places maybe. But I'm not sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Update]: Updated Licensing cache system.
[Refactor]: Refactored some code-base to support type hint.
Test Result