Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formula scene/play mode variables #7758

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

nuoun
Copy link
Contributor

@nuoun nuoun commented Aug 14, 2024

  • Adds scene_mode, poly_mode, split_point
  • Renames is_rendering_to_ui -> is_rendering_to_UI

- Adds scene_mode, poly_mode, split_point
- Renames is_rendering_to_ui -> is_rendering_to_UI
@mkruselj
Copy link
Collaborator

mkruselj commented Aug 14, 2024

I don't think capitalizing UI in variable name is needed or necessary. I would suggest reverting that, please.

@nuoun
Copy link
Contributor Author

nuoun commented Aug 14, 2024

Added a little check that converts to channel number for the channel split mode. I think this is good to go and I hope this will be the last variable that gets added for now as there are already a lot to keep track of.

@nuoun
Copy link
Contributor Author

nuoun commented Aug 14, 2024

I don't think capitalizing UI in variable name is needed or necessary. I would suggest reverting that, please.

I was going to say it would be consistent with how we named other variables with acronyms in them but unfortunately it's not really consistent either way so I'll change that back.

@nuoun
Copy link
Contributor Author

nuoun commented Aug 14, 2024

One last rename: poly_mode should be play_mode user facing.

@mkruselj mkruselj merged commit 821dd5f into surge-synthesizer:main Aug 14, 2024
10 checks passed
@nuoun nuoun deleted the formula-playmodeparam branch August 17, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants