Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prune some log traces from examples #966

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Prune some log traces from examples #966

merged 3 commits into from
Oct 24, 2024

Conversation

Dhghomon
Copy link
Contributor

@Dhghomon Dhghomon commented Oct 24, 2024

The flag --log trace shows up in a lot of examples but for the most part doesn't fit the example and can even result in decreased performance as the database spends time logging everything. See surrealdb/surrealist#532 (comment)

This removes them in places where verbosity is not the subject, and makes it clear in other parts that it is being added to make the output verbose so that the reader knows that --log trace is only there for that specific case and doesn't need to be there otherwise.

Edit: Also replaces most of the remaining with --debug which is enough to demonstrate a more verbose output.

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for surrealdb-docs ready!

Name Link
🔨 Latest commit 9224f1a
🔍 Latest deploy log https://app.netlify.com/sites/surrealdb-docs/deploys/671a57a3b1c2560008327c32
😎 Deploy Preview https://deploy-preview-966--surrealdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Dhghomon Dhghomon marked this pull request as ready for review October 24, 2024 14:02
@Dhghomon Dhghomon merged commit 6e5efd3 into main Oct 24, 2024
6 checks passed
@Dhghomon Dhghomon deleted the prune-the-log-traces branch October 24, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants