Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve dev UX by removing unnecessary toil #236

Merged
merged 2 commits into from
Sep 15, 2023
Merged

improve dev UX by removing unnecessary toil #236

merged 2 commits into from
Sep 15, 2023

Commits on Sep 15, 2023

  1. fix(bundle): update bundle only if there are changes 

    Previously, `make bundle` will update the `createdAt` of the bundle CSV
file even if there aren't any changes to the config. This requires PRs
to be rebased to resolve the conflict in createdAt. This PR changes the
bundle generation to revert the CSV file if the only change detected is
for the `createdAt` timestamp, there by saving us from unnecessary
rebases.

Signed-off-by: Sunil Thaha <[email protected]>
    @sthaha
    sthaha committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    120df12 View commit details
    Browse the repository at this point in the history

  2. cleanup: hack/tools install script 

    * Adds make target for installing oc
* Removes (ab)use of [[ $(command -v ...) ]] with command -v

Signed-off-by: Sunil Thaha <[email protected]>
    @sthaha
    sthaha committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    6a01f5f View commit details
    Browse the repository at this point in the history