Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added options for enabling cURL verbose output and disabling ssl cert… #49

Merged
merged 5 commits into from
Jun 2, 2015

Conversation

netjunki
Copy link

Adds two new cli options:

  • --curl-verbose: Put cURL into verbose mode for extra debugging power
  • --curl-insecure-ssl: Disable cURL host and peer cert verification

@svanoort
Copy link
Owner

svanoort commented Jun 1, 2015

Giving this one a closer review. I'd like to use the following standard for arguments: nothing prefixed by "curl" (it's assumed), and all ssl options start with "ssl." The reason for that is that I am adding several SSL options in the near future, and they all go together.

Do you mind renaming the arguments/options? Thanks!

@netjunki
Copy link
Author

netjunki commented Jun 1, 2015

Not at all. Though I apparently shouldn't have been trying to do this just after waking up. :-)

@svanoort svanoort merged commit 1be32ae into svanoort:master Jun 2, 2015
@svanoort
Copy link
Owner

svanoort commented Jun 2, 2015

@netjunki We've all had those days. :-)

@svanoort svanoort added this to the Release 1.5.0 milestone Oct 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants