Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapter-vercel shouldn't wipe .vercel/output #5207

Closed
Rich-Harris opened this issue Jun 15, 2022 · 1 comment · Fixed by #5555
Closed

adapter-vercel shouldn't wipe .vercel/output #5207

Rich-Harris opened this issue Jun 15, 2022 · 1 comment · Fixed by #5555
Labels
bug Something isn't working pkg:adapter-vercel Pertaining to the Vercel adapter

Comments

@Rich-Harris
Copy link
Member

Describe the bug

This line is problematic...

builder.rimraf(dir);
...because it wipes files that vc build places in that directory. vc build also empties the directory, which is enough.

Reproduction

Going to break my own rule and skip a repro for this one, since it's best demonstrated with a canary version of the Vercel CLI

Logs

No response

System Info

latest everything

Severity

annoyance

Additional Information

No response

@benmccann benmccann added bug Something isn't working pkg:adapter-vercel Pertaining to the Vercel adapter labels Jun 23, 2022
@mrkldshv
Copy link
Contributor

mrkldshv commented Jul 9, 2022

Hey! I'm thinking to take this issue. As mentioned in the issue, vercel build removes potentially existing output directory, so I guess we can just remove this line from the adapter code, because it does the same.

Rich-Harris added a commit that referenced this issue Jul 16, 2022
* dont remove .vercel/output directory - fixes #5207

* empty out .func dir before repopulating
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pkg:adapter-vercel Pertaining to the Vercel adapter
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants