-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"App updated" notification mechanism seems broken #8948
Comments
For now, you can remove the The main cause of the issue is that multiple different date values are set during the build process, only when manually specifying Maybe the fix is to call it once at the start of build and pass that string manually to different parts of the build process? |
I'm tending towards saying that, if you specify a If that's the direction we go, that would make this a documentation issue. |
Thanks, beloved maintainers !
Yes, I was wondering if we weren't a bit mislead by documentation. It states that default value is On our side, I think we're currently fine with deleting the |
Doc update attempt, following sveltejs#8948
@Conduitry made a small doc update attempt |
* Update index.d.ts Doc update attempt, following #8948 * Update index.d.ts Better formulation * Update packages/kit/types/index.d.ts * changeset --------- Co-authored-by: Rich Harris <[email protected]>
closed via #8956 |
Describe the bug
In our app we use:
https://kit.svelte.d:ev/docs/modules#$app-stores-updated
and the following config:
It worked quite well.
Recently we made an deps bump (sveltekit 1.0.11 => 1.3.9), and the bug started to show on our environments.
The bug:
the polling to
APP_URL/_app/version.json
works and theupdated
store keep beingtrue
. Our notification component telling the user to reload the app show itself at each poll.Reproduction
https://stackblitz.com/edit/sveltejs-kit-template-default-s85ex1?file=src/routes/+page.svelte
(Bug shows in
npm run build && npm run preview
mode or when deployed).Locally, I reproduced it on a brand new sveltekit project created with
npm create svelte@latest
Logs
No response
System Info
Severity
blocking an upgrade
Additional Information
When I search in built/generates files, I find the timestamp returned by the url polled (
APP_URL/_app/version.json
) in output/client/_app/version.jsonThe text was updated successfully, but these errors were encountered: