Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: tidying up types #1013

Merged
merged 4 commits into from
Apr 14, 2021
Merged

chore: tidying up types #1013

merged 4 commits into from
Apr 14, 2021

Conversation

ignatiusmb
Copy link
Member

A prelude before moving types into its own folder as mentioned in #980 (comment). This PR actions consists of

No tests or changeset should be needed as this should not change anything


There's also a couple more things I'd like to do but not sure what the general opinion here is, this suggestions could be applied here or in a separate PR (or not at all)

  1. only exported types from types.d.ts are exposed to the end-user
    a. it might be better to have not-exported to be placed in other file (maybe internal or config), or
    b. just put it directly in the arguments since it's only used once, e.g. AdapterUtils
  2. continuing 1b, types used only once like ParameterizedBody can be removed and placed directly (inline)

packages/kit/types.d.ts Outdated Show resolved Hide resolved
@benmccann
Copy link
Member

lgtm except for maybe the handle name

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the handle param name I suggest input

@benmccann benmccann merged commit 084099c into sveltejs:master Apr 14, 2021
@ignatiusmb ignatiusmb deleted the chore/clean-up branch April 14, 2021 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants