Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return plaintext 404 for anything under appDir #11597

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Jan 10, 2024

closes #9802. Any requests to /_app/* (other than /_app/env.js) that make it to the SvelteKit server (i.e. they're not already handled by a static webserver) immediately result in a plaintext 404, instead of doing anything more involved.

Today:

With this PR:

@Conduitry since this was your issue, thoughts on a) whether this is technically a breaking change and b) whether this plaintext response suffices or we should use src/error.html?


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Jan 10, 2024

🦋 Changeset detected

Latest commit: 1cc2910

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I would prefer the error template, to at least give users some control over what this returns.

@Rich-Harris
Copy link
Member Author

yeah, that's reasonable. then again we issue plaintext responses for reroute errors, malformed URIs, paths above base and some other cases, so we should probably keep it like this for consistency and then decide if we want to change all of them

@Rich-Harris Rich-Harris merged commit 553e14c into main Jan 11, 2024
13 checks passed
@Rich-Harris Rich-Harris deleted the gh-9802 branch January 11, 2024 20:21
@github-actions github-actions bot mentioned this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Render 404s internally for kit.appDir assets
2 participants