feat: pass validated svelte config to adapters #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jthegedus
commented
May 26, 2021
|
The changelock change may have happened because you are on a different version of pnpm (not latest major perhaps) |
I am on |
benmccann
reviewed
May 26, 2021
benmccann
reviewed
May 26, 2021
…hub.com/jthegedus/kit into feat/computed-svelte-config-for-adapter
|
thanks! |
sidharthv96
added a commit
to sidharthv96/kit
that referenced
this pull request
May 29, 2021
* 'master' of https://github.com/sveltejs/kit: Version Packages (next) (sveltejs#1543) type fixes for adapter-node and adapter-static (sveltejs#1578) Upgrade to Vite 2.3.3 (sveltejs#1580) fix: improve getRawBody parsing & handle error(s) (sveltejs#1528) create-svelte: add svelte-check for TS (sveltejs#1556) pass validated svelte config to adapters (sveltejs#1559) types: group related and reduce potential inconsistencies (sveltejs#1539) Use sveltekit tag on StackOverflow (sveltejs#1558) Fix create-svelte build-template script (sveltejs#1555) Remove err param from Polka .listen() callback (sveltejs#1550) bump: polka and sirv versions (sveltejs#1548) svelte-kit package (sveltejs#1499)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass validated Svelte config to Adapters.
As vaguely discussed in #1435 and #1436 adapters may need the svelte config settings, but currently must parse the files themselves, which is brittle and unnecessary.
An example of this need comes from adapters reading specific cloud provider config to determine input and output dirs. The Firebase adapter reads the
firebase.jsonfile to determine the output dir for the static assets, but by default this ispublicand so conflicts with the default ofkit.files.assets. The adapter checks that these are different, but must first read the svelte config to determine the actual value ofsvelte.config.js:kit.files.assetsand deal with it not being listed because we are reading the object before SvelteKit defaults are applied etc.Closes #1435
Following the contribution guide,
pnpm ichanged the lockfile 🤷Before submitting the PR, please make sure you do the following
Tests
pnpm testand lint the project withpnpm lintChangesets
pnpx changesetand following the prompts